Linux-Kernel Archive: [PATCH] mips: lantiq: falcon: Fix refcount leak bug in sysctrl [PATCH] mips: lantiq: falcon: Fix refcount leak bug in sysctrl From: Liang He Date: Fri Jun 17 2022 - 08:20:27 EST Next message: K Prateek Nayak: "Re: [PATCH v4 1/2] sched: Add per_cpu cluster domain info and cpus_share_resources API" Previous message: Cezary Rojewski: "Re: [PATCH 01/11] ASoC: Intel: catpt: use pm_runtime_resume_and_get()" Next in thread: Thomas Bogendoerfer: "Re: [PATCH] mips: lantiq: falcon: Fix refcount leak bug in sysctrl" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] In ltq_soc_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- arch/mips/lantiq/falcon/sysctrl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/mips/lantiq/falcon/sysctrl.c b/arch/mips/lantiq/falcon/sysctrl.c index 5204fc6d6d50..1187729d8cbb 100644 --- a/arch/mips/lantiq/falcon/sysctrl.c +++ b/arch/mips/lantiq/falcon/sysctrl.c @@ -208,6 +208,12 @@ void __init ltq_soc_init(void) of_address_to_resource(np_sysgpe, 0, &res_sys[2])) panic("Failed to get core resources"); + of_node_put(np_status); + of_node_put(np_ebu); + of_node_put(np_sys1); + of_node_put(np_syseth); + of_node_put(np_sysgpe); + if ((request_mem_region(res_status.start, resource_size(&res_status), res_status.name) < 0) || (request_mem_region(res_ebu.start, resource_size(&res_ebu), -- 2.25.1 Next message: K Prateek Nayak: "Re: [PATCH v4 1/2] sched: Add per_cpu cluster domain info and cpus_share_resources API" Previous message: Cezary Rojewski: "Re: [PATCH 01/11] ASoC: Intel: catpt: use pm_runtime_resume_and_get()" Next in thread: Thomas Bogendoerfer: "Re: [PATCH] mips: lantiq: falcon: Fix refcount leak bug in sysctrl" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
