Linux-Kernel Archive: [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl From: Liang He Date: Fri Jun 17 2022 - 08:25:21 EST Next message: Wim Van Sebroeck: "[GIT PULL REQUEST] watchdog - v5.19-rc Fixes" Previous message: Dmitry Osipenko: "[PATCH v1] PM: hibernate: Use kernel_can_power_off()" Next in thread: Thomas Bogendoerfer: "Re: [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] In ltq_soc_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- arch/mips/lantiq/xway/sysctrl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c index 084f6caba5f2..d444a1b98a72 100644 --- a/arch/mips/lantiq/xway/sysctrl.c +++ b/arch/mips/lantiq/xway/sysctrl.c @@ -441,6 +441,10 @@ void __init ltq_soc_init(void) of_address_to_resource(np_ebu, 0, &res_ebu)) panic("Failed to get core resources"); + of_node_put(np_pmu); + of_node_put(np_cgu); + of_node_put(np_ebu); + if (!request_mem_region(res_pmu.start, resource_size(&res_pmu), res_pmu.name) || !request_mem_region(res_cgu.start, resource_size(&res_cgu), -- 2.25.1 Next message: Wim Van Sebroeck: "[GIT PULL REQUEST] watchdog - v5.19-rc Fixes" Previous message: Dmitry Osipenko: "[PATCH v1] PM: hibernate: Use kernel_can_power_off()" Next in thread: Thomas Bogendoerfer: "Re: [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
