Linux-Kernel Archive: Re: [PATCH 1/2] dmaengine: mediatek-cqdma: Add SoC-specific match data Re: [PATCH 1/2] dmaengine: mediatek-cqdma: Add SoC-specific match data From: kernel test robot Date: Tue May 03 2022 - 09:33:02 EST Next message: Baolin Wang: "Re: [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping" Previous message: kernel test robot: "Re: [PATCH 1/2] audit: add call argument to socketcall auditing" In reply to: AngeloGioacchino Del Regno: "[PATCH 1/2] dmaengine: mediatek-cqdma: Add SoC-specific match data" Next in thread: AngeloGioacchino Del Regno: "[PATCH 2/2] dmaengine: mediatek-cqdma: Add support for MediaTek MT6795" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] Hi AngeloGioacchino, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vkoul-dmaengine/next] [also build test WARNING on v5.18-rc5 next-20220503] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/MediaTek-Helio-X10-MT6795-CQDMA-driver/20220503-185610 base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220503/202205032104.sDnKlXcO-lkp@xxxxxxxxx/config) compiler: mips-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1516c04b4553b4a3037e86dada37c202af23e4b3 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review AngeloGioacchino-Del-Regno/MediaTek-Helio-X10-MT6795-CQDMA-driver/20220503-185610 git checkout 1516c04b4553b4a3037e86dada37c202af23e4b3 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/dma/mediatek/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/dma/mediatek/mtk-cqdma.c: In function 'mtk_cqdma_start': drivers/dma/mediatek/mtk-cqdma.c:243:42: error: implicit declaration of function 'to_cqma_dev'; did you mean 'to_cqdma_dev'? [-Werror=implicit-function-declaration] 243 | struct mtk_cqdma_device *cqdma = to_cqma_dev(cvd->ch); | ^~~~~~~~~~~ | to_cqdma_dev >> drivers/dma/mediatek/mtk-cqdma.c:243:42: warning: initialization of 'struct mtk_cqdma_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/dma/mediatek/mtk-cqdma.c:259:30: error: 'struct mtk_cqdma_device' has no member named 'plat' 259 | mtk_dma_set(pc, cqdma->plat->reg_src2, 0); | ^~ drivers/dma/mediatek/mtk-cqdma.c:267:30: error: 'struct mtk_cqdma_device' has no member named 'plat' 267 | mtk_dma_set(pc, cqdma->plat->reg_dst2, 0); | ^~ drivers/dma/mediatek/mtk-cqdma.c: At top level: drivers/dma/mediatek/mtk-cqdma.c:754:54: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 754 | static const struct mtk_cqdma_plat_data cqdma_mt6765 { | ^ drivers/dma/mediatek/mtk-cqdma.c:760:59: error: 'cqdma_mt6765' undeclared here (not in a function) 760 | { .compatible = "mediatek,mt6765-cqdma", .data = &cqdma_mt6765 }, | ^~~~~~~~~~~~ drivers/dma/mediatek/mtk-cqdma.c: In function 'mtk_cqdma_probe': drivers/dma/mediatek/mtk-cqdma.c:777:14: error: 'struct mtk_cqdma_device' has no member named 'plat' 777 | cqdma->plat = device_get_match_data(&pdev->dev); | ^~ drivers/dma/mediatek/mtk-cqdma.c:778:18: error: 'struct mtk_cqdma_device' has no member named 'plat' 778 | if (cqdma->plat) | ^~ cc1: some warnings being treated as errors vim +243 drivers/dma/mediatek/mtk-cqdma.c 239 240 static void mtk_cqdma_start(struct mtk_cqdma_pchan *pc, 241 struct mtk_cqdma_vdesc *cvd) 242 { > 243 struct mtk_cqdma_device *cqdma = to_cqma_dev(cvd->ch); 244 245 /* wait for the previous transaction done */ 246 if (mtk_cqdma_poll_engine_done(pc, true) < 0) 247 dev_err(cqdma2dev(to_cqdma_dev(cvd->ch)), "cqdma wait transaction timeout\n"); 248 249 /* warm reset the dma engine for the new transaction */ 250 mtk_dma_set(pc, MTK_CQDMA_RESET, MTK_CQDMA_WARM_RST_BIT); 251 if (mtk_cqdma_poll_engine_done(pc, true) < 0) 252 dev_err(cqdma2dev(to_cqdma_dev(cvd->ch)), "cqdma warm reset timeout\n"); 253 254 /* setup the source */ 255 mtk_dma_set(pc, MTK_CQDMA_SRC, cvd->src & MTK_CQDMA_ADDR_LIMIT); 256 #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT 257 mtk_dma_set(pc, cqdma->plat->reg_src2, cvd->src >> MTK_CQDMA_ADDR2_SHFIT); 258 #else 259 mtk_dma_set(pc, cqdma->plat->reg_src2, 0); 260 #endif 261 262 /* setup the destination */ 263 mtk_dma_set(pc, MTK_CQDMA_DST, cvd->dest & MTK_CQDMA_ADDR_LIMIT); 264 #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT 265 mtk_dma_set(pc, cqdma->plat->reg_dst2, cvd->dest >> MTK_CQDMA_ADDR2_SHFIT); 266 #else 267 mtk_dma_set(pc, cqdma->plat->reg_dst2, 0); 268 #endif 269 270 /* setup the length */ 271 mtk_dma_set(pc, MTK_CQDMA_LEN1, cvd->len); 272 273 /* start dma engine */ 274 mtk_dma_set(pc, MTK_CQDMA_EN, MTK_CQDMA_EN_BIT); 275 } 276 -- 0-DAY CI Kernel Test Service https://01.org/lkp Next message: Baolin Wang: "Re: [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping" Previous message: kernel test robot: "Re: [PATCH 1/2] audit: add call argument to socketcall auditing" In reply to: AngeloGioacchino Del Regno: "[PATCH 1/2] dmaengine: mediatek-cqdma: Add SoC-specific match data" Next in thread: AngeloGioacchino Del Regno: "[PATCH 2/2] dmaengine: mediatek-cqdma: Add support for MediaTek MT6795" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
