Linux-Kernel Archive: [PATCH 3.12 092/142] Bluetooth: Avoid use of session socket after the session gets freed [PATCH 3.12 092/142] Bluetooth: Avoid use of session socket after the session gets freed From: Jiri Slaby Date: Fri Sep 26 2014 - 06:06:52 EST Next message: Christian Borntraeger: "Re: [PATCH 3.12 040/142] s390/locking: Reenable optimistic spinning" Previous message: Jiri Slaby: "[PATCH 3.12 082/142] ASoC: rt5640: Do not allow regmap to use bulk read-write operations" In reply to: Jiri Slaby: "[PATCH 3.12 082/142] ASoC: rt5640: Do not allow regmap to use bulk read-write operations" Next in thread: Jiri Slaby: "[PATCH 3.12 103/142] xfs: don't zero partial page cache pages during O_DIRECT writes" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] From: Vignesh Raman 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit 32333edb82fb2009980eefc5518100068147ab82 upstream. The commits 08c30aca9e698faddebd34f81e1196295f9dc063 "Bluetooth: Remove RFCOMM session refcnt" and 8ff52f7d04d9cc31f1e81dcf9a2ba6335ed34905 "Bluetooth: Return RFCOMM session ptrs to avoid freed session" allow rfcomm_recv_ua and rfcomm_session_close to delete the session (and free the corresponding socket) and propagate NULL session pointer to the upper callers. Additional fix is required to terminate the loop in rfcomm_process_rx function to avoid use of freed 'sk' memory. The issue is only reproducible with kernel option CONFIG_PAGE_POISONING enabled making freed memory being changed and filled up with fixed char value used to unmask use-after-free issues. Signed-off-by: Vignesh Raman Signed-off-by: Vitaly Kuzmichev Acked-by: Dean Jenkins Signed-off-by: Marcel Holtmann Signed-off-by: Jiri Slaby --- net/bluetooth/rfcomm/core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c index ca957d34b0c8..19ba192e9dbf 100644 --- a/net/bluetooth/rfcomm/core.c +++ b/net/bluetooth/rfcomm/core.c @@ -1857,10 +1857,13 @@ static struct rfcomm_session *rfcomm_process_rx(struct rfcomm_session *s) /* Get data directly from socket receive queue without copying it. */ while ((skb = skb_dequeue(&sk->sk_receive_queue))) { skb_orphan(skb); - if (!skb_linearize(skb)) + if (!skb_linearize(skb)) { s = rfcomm_recv_frame(s, skb); - else + if (!s) + break; + } else { kfree_skb(skb); + } } if (s && (sk->sk_state == BT_CLOSED)) -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ Next message: Christian Borntraeger: "Re: [PATCH 3.12 040/142] s390/locking: Reenable optimistic spinning" Previous message: Jiri Slaby: "[PATCH 3.12 082/142] ASoC: rt5640: Do not allow regmap to use bulk read-write operations" In reply to: Jiri Slaby: "[PATCH 3.12 082/142] ASoC: rt5640: Do not allow regmap to use bulk read-write operations" Next in thread: Jiri Slaby: "[PATCH 3.12 103/142] xfs: don't zero partial page cache pages during O_DIRECT writes" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
