Linux-Kernel Archive: Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when using handle_fpe Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when using handle_fpe From: Stephen Zhang Date: Tue Apr 26 2022 - 21:58:16 EST Next message: Damien Le Moal: "Re: [PATCH v4 01/10] block: Introduce queue limits for copy-offload support" Previous message: YueHaibing: "Re: [PATCH -next] reboot: Fix build warning without CONFIG_SYSFS" In reply to: Maciej W. Rozycki: "Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when using handle_fpe" Next in thread: Maciej W. Rozycki: "Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when using handle_fpe" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] Maciej W. Rozycki 于2022年4月27日周三 08:40写道： > > No need to conditionalise this either, because `cpu_has_fpu' is forced 0 > (in arch/mips/include/asm/cpu-features.h) if !CONFIG_MIPS_FP_SUPPORT. So > this code translates to: > > if (0 && !0) > set_except_vector(15, handle_fpe); > > in the preprocessor if CONFIG_MIPS_FP_SUPPORT is unset and is optimised > away. Otherwise it should be written as: > > if (IS_ENABLED(CONFIG_MIPS_FP_SUPPORT) && ... > > so as not to clutter C code with #ifdef, as per our coding style. > > Maciej Thanks for your comment. Do you mean the following code: if (0 && !0) set_except_vector(15, handle_fpe); will be optimised away if !CONFIG_MIPS_FP_SUPPORT? But we did get “undefined reference to `handle_fpe” error when compiled with !CONFIG_MIPS_FP_SUPPORT. Next message: Damien Le Moal: "Re: [PATCH v4 01/10] block: Introduce queue limits for copy-offload support" Previous message: YueHaibing: "Re: [PATCH -next] reboot: Fix build warning without CONFIG_SYSFS" In reply to: Maciej W. Rozycki: "Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when using handle_fpe" Next in thread: Maciej W. Rozycki: "Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when using handle_fpe" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
