Linux-Kernel Archive: Re: [PATCH] device property: Fix recent breakage of fwnode_get_next_parent_dev() Re: [PATCH] device property: Fix recent breakage of fwnode_get_next_parent_dev() From: Rafael J. Wysocki Date: Thu May 05 2022 - 08:21:08 EST Next message: Ren Zhijie: "[PATCH -next] platform/x86: amd-pmc: Fix build error unused-function" Previous message: Tiezhu Yang: "[PATCH 2/2] MIPS: Use NOKPROBE_SYMBOL() instead of __kprobes annotation" In reply to: Andy Shevchenko: "Re: [PATCH] device property: Fix recent breakage of fwnode_get_next_parent_dev()" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] On Sun, May 1, 2022 at 9:50 AM Andy Shevchenko
wrote: > > On Sat, Apr 30, 2022 at 3:00 PM Douglas Anderson wrote: > > > > Due to a subtle typo, instead of commit 87ffea09470d ("device > > property: Introduce fwnode_for_each_parent_node()") being a no-op > > change, it ended up causing the display on my sc7180-trogdor-lazor > > device from coming up unless I added "fw_devlink=off" to my kernel > > command line. Fix the typo. > > Sorry and merci pour la fix! > Reviewed-by: Andy Shevchenko Applied, thanks! > > Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") > > Signed-off-by: Douglas Anderson > > --- > > > > drivers/base/property.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/base/property.c b/drivers/base/property.c > > index 36401cfe432c..52e85dcb20b5 100644 > > --- a/drivers/base/property.c > > +++ b/drivers/base/property.c > > @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode) > > struct device *dev; > > > > fwnode_for_each_parent_node(fwnode, parent) { > > - dev = get_dev_from_fwnode(fwnode); > > + dev = get_dev_from_fwnode(parent); > > if (dev) { > > fwnode_handle_put(parent); > > return dev; > > -- > > 2.36.0.464.gb9c8b46e94-goog > > > > > -- > With Best Regards, > Andy Shevchenko Next message: Ren Zhijie: "[PATCH -next] platform/x86: amd-pmc: Fix build error unused-function" Previous message: Tiezhu Yang: "[PATCH 2/2] MIPS: Use NOKPROBE_SYMBOL() instead of __kprobes annotation" In reply to: Andy Shevchenko: "Re: [PATCH] device property: Fix recent breakage of fwnode_get_next_parent_dev()" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
