Linux-Kernel Archive: Re: [PATCH] mips: mti-malta: Fix refcount leak in malta-time.c Re: [PATCH] mips: mti-malta: Fix refcount leak in malta-time.c From: Thomas Bogendoerfer Date: Tue Jun 21 2022 - 11:22:01 EST Next message: Thomas Bogendoerfer: "Re: [PATCH v2] mips/pic32/pic32mzda: Fix refcount leak bugs" Previous message: Thomas Bogendoerfer: "Re: [PATCH v6 1/2] mips: dts: ingenic: Add TCU clock to x1000/x1830 tcu device node" In reply to: Liang He: "[PATCH] mips: mti-malta: Fix refcount leak in malta-time.c" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] On Thu, Jun 16, 2022 at 10:27:56PM +0800, Liang He wrote: > In update_gic_frequency_dt(), of_find_compatible_node() will return > a node pointer with refcount incremented. We should use of_node_put() > when it is not used anymore. > > Signed-off-by: Liang He > --- > arch/mips/mti-malta/malta-time.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/mti-malta/malta-time.c b/arch/mips/mti-malta/malta-time.c > index bbf1e38e1431..2cb708cdf01a 100644 > --- a/arch/mips/mti-malta/malta-time.c > +++ b/arch/mips/mti-malta/malta-time.c > @@ -214,6 +214,8 @@ static void update_gic_frequency_dt(void) > > if (of_update_property(node, &gic_frequency_prop) < 0) > pr_err("error updating gic frequency property\n"); > + > + of_node_put(node); > } > > #endif > -- > 2.25.1 applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] Next message: Thomas Bogendoerfer: "Re: [PATCH v2] mips/pic32/pic32mzda: Fix refcount leak bugs" Previous message: Thomas Bogendoerfer: "Re: [PATCH v6 1/2] mips: dts: ingenic: Add TCU clock to x1000/x1830 tcu device node" In reply to: Liang He: "[PATCH] mips: mti-malta: Fix refcount leak in malta-time.c" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
