Linux-Kernel Archive: Re: [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places. Re: [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places. From: Uwe Kleine-König Date: Tue Jun 21 2022 - 15:48:39 EST Next message: Dmitry Baryshkov: "Re: [PATCH v2 1/2] dt-bindings: arm: qcom: document qcom,msm-id and qcom,board-id" Previous message: Dan Williams: "Re: [PATCH V11 5/8] cxl/port: Read CDAT table" In reply to: Jiang Jian: "[PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places." Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] The Subject speaks about two places, there is only one change here however? On Wed, Jun 22, 2022 at 12:21:14AM +0800, Jiang Jian wrote: > file: ./arch/mips/sgi-ip22/ip22-gio.c > line: 44 > * @ids: array of of device match structures to search in > changed to > * @ids: array of device match structures to search in I know writing a sensible commit log is hard, but this is really very useless. This is a plain repetition of the diff below. Additionally I'm not sure the patch is right. The comment speaks about of (= open firmware) devices. So if you want to improve here, maybe make it read + * @match: array gio_device_id structures to search in But please double check this is indeed sensible; I didn't. (But yes, @ids is wrong, the parameter is named match.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | Attachment: signature.asc Description: PGP signature Next message: Dmitry Baryshkov: "Re: [PATCH v2 1/2] dt-bindings: arm: qcom: document qcom,msm-id and qcom,board-id" Previous message: Dan Williams: "Re: [PATCH V11 5/8] cxl/port: Read CDAT table" In reply to: Jiang Jian: "[PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places." Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
