Linux-Kernel Archive: [PATCH 5.15 829/913] wireguard: socket: free skb in send6 when ipv6 is disabled [PATCH 5.15 829/913] wireguard: socket: free skb in send6 when ipv6 is disabled From: Greg Kroah-Hartman Date: Tue Apr 05 2022 - 21:31:57 EST Next message: Greg Kroah-Hartman: "[PATCH 5.15 415/913] ixgbe: respect metadata on XSK Rx to skb" Previous message: Jonathan Corbet: "Re: [PATCH] w1: w1_therm: Document Maxim MAX31850 thermoelement IF." In reply to: Greg Kroah-Hartman: "[PATCH 5.15 531/913] ath10k: Fix error handling in ath10k_setup_msa_resources" Next in thread: Greg Kroah-Hartman: "[PATCH 5.15 415/913] ixgbe: respect metadata on XSK Rx to skb" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] From: Wang Hai commit bbbf962d9460194993ee1943a793a0a0af4a7fbf upstream. I got a memory leak report: unreferenced object 0xffff8881191fc040 (size 232): comm "kworker/u17:0", pid 23193, jiffies 4295238848 (age 3464.870s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] slab_post_alloc_hook+0x84/0x3b0 [] kmem_cache_alloc_node+0x167/0x340 [] __alloc_skb+0x1db/0x200 [] wg_socket_send_buffer_to_peer+0x3d/0xc0 [] wg_packet_send_handshake_initiation+0xfa/0x110 [] wg_packet_handshake_send_worker+0x21/0x30 [] process_one_work+0x2e8/0x770 [] worker_thread+0x4a/0x4b0 [] kthread+0x120/0x160 [] ret_from_fork+0x1f/0x30 In function wg_socket_send_buffer_as_reply_to_skb() or wg_socket_send_ buffer_to_peer(), the semantics of send6() is required to free skb. But when CONFIG_IPV6 is disable, kfree_skb() is missing. This patch adds it to fix this bug. Signed-off-by: Wang Hai Fixes: e7096c131e51 ("net: WireGuard secure network tunnel") Signed-off-by: Jason A. Donenfeld Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireguard/socket.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/wireguard/socket.c +++ b/drivers/net/wireguard/socket.c @@ -160,6 +160,7 @@ out: rcu_read_unlock_bh(); return ret; #else + kfree_skb(skb); return -EAFNOSUPPORT; #endif } Next message: Greg Kroah-Hartman: "[PATCH 5.15 415/913] ixgbe: respect metadata on XSK Rx to skb" Previous message: Jonathan Corbet: "Re: [PATCH] w1: w1_therm: Document Maxim MAX31850 thermoelement IF." In reply to: Greg Kroah-Hartman: "[PATCH 5.15 531/913] ath10k: Fix error handling in ath10k_setup_msa_resources" Next in thread: Greg Kroah-Hartman: "[PATCH 5.15 415/913] ixgbe: respect metadata on XSK Rx to skb" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
