Linux-Kernel Archive: [PATCH 4.9 168/264] random: re-add removed comment about get_random_{u32,u64} reseeding [PATCH 4.9 168/264] random: re-add removed comment about get_random_{u32,u64} reseeding From: Greg Kroah-Hartman Date: Thu Jun 23 2022 - 13:04:30 EST Next message: Greg Kroah-Hartman: "[PATCH 4.9 185/264] mips: use fallback for random_get_entropy() instead of just c0 random" Previous message: Greg Kroah-Hartman: "[PATCH 4.9 184/264] m68k: use fallback for random_get_entropy() instead of zero" In reply to: Greg Kroah-Hartman: "[PATCH 4.9 184/264] m68k: use fallback for random_get_entropy() instead of zero" Next in thread: Greg Kroah-Hartman: "[PATCH 4.9 185/264] mips: use fallback for random_get_entropy() instead of just c0 random" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] From: "Jason A. Donenfeld" commit dd7aa36e535797926d8eb311da7151919130139d upstream. The comment about get_random_{u32,u64}() not invoking reseeding got added in an unrelated commit, that then was recently reverted by 0313bc278dac ("Revert "random: block in /dev/urandom""). So this adds that little comment snippet back, and improves the wording a bit too. Reviewed-by: Dominik Brodowski Signed-off-by: Jason A. Donenfeld Signed-off-by: Greg Kroah-Hartman --- drivers/char/random.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -227,9 +227,10 @@ static void _warn_unseeded_randomness(co * * These interfaces will return the requested number of random bytes * into the given buffer or as a return value. This is equivalent to - * a read from /dev/urandom. The integer family of functions may be - * higher performance for one-off random integers, because they do a - * bit of buffering. + * a read from /dev/urandom. The u32, u64, int, and long family of + * functions may be higher performance for one-off random integers, + * because they do a bit of buffering and do not invoke reseeding + * until the buffer is emptied. * *********************************************************************/ Next message: Greg Kroah-Hartman: "[PATCH 4.9 185/264] mips: use fallback for random_get_entropy() instead of just c0 random" Previous message: Greg Kroah-Hartman: "[PATCH 4.9 184/264] m68k: use fallback for random_get_entropy() instead of zero" In reply to: Greg Kroah-Hartman: "[PATCH 4.9 184/264] m68k: use fallback for random_get_entropy() instead of zero" Next in thread: Greg Kroah-Hartman: "[PATCH 4.9 185/264] mips: use fallback for random_get_entropy() instead of just c0 random" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
