Linux-Kernel Archive: [FIXME] Comments on serial and MMC changes in MIPS merge [FIXME] Comments on serial and MMC changes in MIPS merge From: Russell King Date: Sat Oct 29 2005 - 17:07:38 EST Next message: Mark Jenkins: "Re: Is sharpzdc_cs.o not a derivitive work of Linux?" Previous message: Alexandre Oliva: "amd64 bitops fix for -Os" Next in thread: Pierre Ossman: "Re: [FIXME] Comments on serial and MMC changes in MIPS merge" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] Some comments on the recent MIPS merge: 1. au1xxx mmc driver mmc_remove_host() does a safe shutdown of the MMC host, removing cards and then powering down. This must be called prior to the driver thinking of tearing anything down. As for those disable_irq()...enable_irq(), are you aware that MMC can start talking to the host as soon as you've called mmc_add_host() ? 2. IP3106 serial driver -#define PORT_MAX_8250 15 /* max port ID */ +#define PORT_IP3106 16 +#define PORT_MAX_8250 16 /* max port ID */ Do not add new port numbers after the 8250 port number range. Add them on the end of the list. Since this will get in the way of additional 8250 ports, it's a serious problem. Please fix ASAP. (btw, I notice that this change was _not_ included with the IP3106 driver you sent for review.) -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ Next message: Mark Jenkins: "Re: Is sharpzdc_cs.o not a derivitive work of Linux?" Previous message: Alexandre Oliva: "amd64 bitops fix for -Os" Next in thread: Pierre Ossman: "Re: [FIXME] Comments on serial and MMC changes in MIPS merge" Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
